diff --git a/go.mod b/go.mod index b609f98de21169bf9f26c39172921643e16fd792..ecaac5ff8d446975687f35ce4315295efa9dd4dc 100644 --- a/go.mod +++ b/go.mod @@ -3,7 +3,7 @@ module git.autistici.org/ai3/tools/acmeserver go 1.14 require ( - git.autistici.org/ai3/go-common v0.0.0-20221125154433-06304016b1da + git.autistici.org/ai3/go-common v0.0.0-20230526131513-5afdaf014661 git.autistici.org/ai3/tools/replds v0.0.0-20220814170053-28106a9463f5 github.com/miekg/dns v1.1.50 github.com/prometheus/client_golang v1.12.2 diff --git a/go.sum b/go.sum index f925beea2dbceaf4521956b54f4a09b6611b4cc4..800202049a493f1e9ae1a131910cdd46e61fb3c1 100644 --- a/go.sum +++ b/go.sum @@ -54,6 +54,8 @@ git.autistici.org/ai3/go-common v0.0.0-20220814151247-39e01d32d5ee h1:EPfpfiG3vK git.autistici.org/ai3/go-common v0.0.0-20220814151247-39e01d32d5ee/go.mod h1:yhMB8VKJBBr+EKMft7MtqHVO73vkwdq/O5sVDTs/CNI= git.autistici.org/ai3/go-common v0.0.0-20221125154433-06304016b1da h1:fizdAjFv2vWz+83IoeRW2L0Shyo3dDquXyQKWRGs4jc= git.autistici.org/ai3/go-common v0.0.0-20221125154433-06304016b1da/go.mod h1:FTGqOGPpuoFg7TiHshYCyp5j1Ab3ek0J0KcS++vEjxw= +git.autistici.org/ai3/go-common v0.0.0-20230526131513-5afdaf014661 h1:QidAfAxaIMWWu52luWF30wvRpv7t+Ic73xxsTUENqSU= +git.autistici.org/ai3/go-common v0.0.0-20230526131513-5afdaf014661/go.mod h1:FTGqOGPpuoFg7TiHshYCyp5j1Ab3ek0J0KcS++vEjxw= git.autistici.org/ai3/tools/replds v0.0.0-20220814170053-28106a9463f5 h1:E5enMbOmQkRkLVbYks2Makfg3wd3fOxYDK9ksGOqS7c= git.autistici.org/ai3/tools/replds v0.0.0-20220814170053-28106a9463f5/go.mod h1:DDsdq6Fs+uWfzRIuj8JncnTrfy+NRwfGHxk6OViV8T0= github.com/Azure/azure-amqp-common-go/v2 v2.1.0/go.mod h1:R8rea+gJRuJR6QxTir/XuEd+YuKoUiazDC/N96FiDEU= diff --git a/vendor/git.autistici.org/ai3/go-common/serverutil/http.go b/vendor/git.autistici.org/ai3/go-common/serverutil/http.go index b2575350bcb11e0099375aee69a3b4f37a3500c7..ebfe6b6f7a914b34d76e4e19ae906f8ba9439b3d 100644 --- a/vendor/git.autistici.org/ai3/go-common/serverutil/http.go +++ b/vendor/git.autistici.org/ai3/go-common/serverutil/http.go @@ -104,13 +104,20 @@ func (config *ServerConfig) buildHTTPHandler(h http.Handler) (http.Handler, *tls return h, tlsConfig, nil } -// Serve HTTP(S) content on the specified address. If config.TLS is -// not nil, enable HTTPS and TLS authentication. -// -// This function will return an error if there are problems creating -// the listener, otherwise it will handle graceful termination on -// SIGINT or SIGTERM and return nil. -func Serve(h http.Handler, config *ServerConfig, addr string) error { +func buildListener(addr string, tlsConfig *tls.Config) (net.Listener, error) { + // Create the net.Listener first, so we can detect + // initialization-time errors safely. + l, err := net.Listen("tcp", addr) + if err != nil { + return nil, err + } + if tlsConfig != nil { + l = tls.NewListener(l, tlsConfig) + } + return l, nil +} + +func buildServer(h http.Handler, config *ServerConfig, addr string) (*http.Server, error) { // Wrap with tracing handler (exclude metrics and other // debugging endpoints). h = tracing.WrapHandler(h, guessEndpointName(addr)) @@ -118,7 +125,7 @@ func Serve(h http.Handler, config *ServerConfig, addr string) error { // Create the top-level HTTP handler with all our additions. hh, tlsConfig, err := config.buildHTTPHandler(h) if err != nil { - return err + return nil, err } // These are not meant to be external-facing servers, so we @@ -131,14 +138,24 @@ func Serve(h http.Handler, config *ServerConfig, addr string) error { TLSConfig: tlsConfig, } - // Create the net.Listener first, so we can detect - // initialization-time errors safely. - l, err := net.Listen("tcp", addr) + return srv, nil +} + +// Serve HTTP(S) content on the specified address. If config.TLS is +// not nil, enable HTTPS and TLS authentication. +// +// This function will return an error if there are problems creating +// the listener, otherwise it will handle graceful termination on +// SIGINT or SIGTERM and return nil. +func Serve(h http.Handler, config *ServerConfig, addr string) error { + srv, err := buildServer(h, config, addr) if err != nil { return err } - if srv.TLSConfig != nil { - l = tls.NewListener(l, srv.TLSConfig) + + l, err := buildListener(addr, srv.TLSConfig) + if err != nil { + return err } // Install a signal handler for gentle process termination. @@ -176,6 +193,38 @@ func Serve(h http.Handler, config *ServerConfig, addr string) error { return nil } +// ServeWithContext operates like Serve but with a controlling Context +// that can be used to stop the HTTP server. +func ServeWithContext(ctx context.Context, h http.Handler, config *ServerConfig, addr string) error { + srv, err := buildServer(h, config, addr) + if err != nil { + return err + } + + l, err := buildListener(addr, srv.TLSConfig) + if err != nil { + return err + } + + go func() { + <-ctx.Done() + + sctx, cancel := context.WithTimeout(context.Background(), gracefulShutdownTimeout) + srv.Shutdown(sctx) // nolint: errcheck + srv.Close() + cancel() + }() + + daemon.SdNotify(false, "READY=1") // nolint + + err = srv.Serve(l) + if err == http.ErrServerClosed { + err = nil + } + + return err +} + func addDefaultHandlers(h http.Handler) http.Handler { root := http.NewServeMux() diff --git a/vendor/git.autistici.org/ai3/go-common/serverutil/tls.go b/vendor/git.autistici.org/ai3/go-common/serverutil/tls.go index 21c002b8baaae892f04f481b84a23e1aa7a34067..b81b0470dc296240ac81c734791e080f8b5416dd 100644 --- a/vendor/git.autistici.org/ai3/go-common/serverutil/tls.go +++ b/vendor/git.autistici.org/ai3/go-common/serverutil/tls.go @@ -123,6 +123,7 @@ func (c *TLSServerConfig) TLSConfig() (*tls.Config, error) { CipherSuites: serverCiphers, MinVersion: tls.VersionTLS12, PreferServerCipherSuites: true, + NextProtos: []string{"h2", "http/1.1"}, } // Require client certificates if a CA is specified. diff --git a/vendor/modules.txt b/vendor/modules.txt index 4323c4d739520203b0068ccdff77f927bc9733ec..d640fc8b02e5f747717dcb507152e2eee3d9677a 100644 --- a/vendor/modules.txt +++ b/vendor/modules.txt @@ -1,4 +1,4 @@ -# git.autistici.org/ai3/go-common v0.0.0-20221125154433-06304016b1da +# git.autistici.org/ai3/go-common v0.0.0-20230526131513-5afdaf014661 ## explicit git.autistici.org/ai3/go-common git.autistici.org/ai3/go-common/clientutil