Skip to content
Snippets Groups Projects
  1. Jun 30, 2019
    • ale's avatar
      Prevent premature cancellation of the HTTP request context · 54f0ac4c
      ale authored
      The Context in the http.Request is bound to the one we give it when
      calling balancedBackend.do(), so we were accessing it out of scope
      when calling the final json.Decode on the response body.
      
      This was not a problem for most *small* requests, as the response Body
      already contains all the data due to having read it along with the
      headers. However, larger response bodies would cause json.Decode to
      call a Read with what at that point is a canceled Context, so the Call
      function would return a mysterious "context canceled" error.
      
      (Note that this change introduces a minor, probably less annoying,
      issue, where we can't reset "resp" between successive calls so we may
      be invoking json.Decode on a non-pristine object if the first call
      fails in some circumstances).
      54f0ac4c
  2. Jan 29, 2019
  3. Nov 16, 2018
  4. Aug 17, 2018
  5. Aug 16, 2018
    • ale's avatar
      Refactor the clientutil package · 193e29e6
      ale authored
      Implement a simpler API for the Backend interface, removing most old
      public methods and replacing them with a single Call() method, making
      the package look a bit more like an actual rpc package (so, hopefully,
      easier to replace in the future).
      193e29e6
Loading