go vet fixes

cmd/radioctl/radioctl.go

@@ -314,7 +314,7 @@ func init() {
 func usage() {
 	fmt.Fprintf(os.Stderr, "Usage: %s\n\nGlobal options:\n", cmdr.UsageLine)
 	flag.PrintDefaults()
-	fmt.Fprintln(os.Stderr, "\nType \"radioctl help\" for more documentation.\n")
+	fmt.Fprintf(os.Stderr, "\nType \"radioctl help\" for more documentation.\n\n")
 }
 
 func main() {

fe/loadbalancing.go

@@ -39,7 +39,7 @@ func (wlp weightedListenersPolicy) GetNode(nodes []*autoradio.NodeStatus) *autor
 	weightBase := 1000000
 	for _, n := range nodes {
 		w := weightBase / (n.NumListeners() + 1)
-		choices = append(choices, randutil.Choice{w, n})
+		choices = append(choices, randutil.Choice{Weight: w, Item: n})
 	}
 	result, err := randutil.WeightedChoice(choices)
 	if err != nil {

instrumentation/stats.go

@@ -24,7 +24,7 @@ var (
 func init() {
 	hostname, err := os.Hostname()
 	if err != nil {
-		log.Fatal("Could not determine hostname: %v", err)
+		log.Fatalf("Could not determine hostname: %v", err)
 	}
 	prefix = fmt.Sprintf("autoradio.%s.", hostname)
 }
@@ -33,7 +33,7 @@ func getClient() *statsd.Client {
 	clientInit.Do(func() {
 		c, err := statsd.New(*statsdServer, prefix)
 		if err != nil {
-			log.Fatal("Error initializing instrumentation: %v", err)
+			log.Fatalf("Error initializing instrumentation: %v", err)
 		}
 		client = c
 	})

node/icecast_config.go

@@ -151,7 +151,7 @@ func newIcecastConfig(publicIp string) *icecastConfig {
 	adminPw := getIcecastAdminPassword()
 
 	return &icecastConfig{
-		XMLName: xml.Name{"", "icecast"},
+		XMLName: xml.Name{Local: "icecast"},
 		Limits: iceLimitsConfig{
 			Clients:       maxClients,
 			Sources:       maxClients / 2,