Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
X
x509ca
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
ale
x509ca
Commits
ec3841b6
Commit
ec3841b6
authored
7 years ago
by
ale
Browse files
Options
Downloads
Patches
Plain Diff
Remove TODO
parent
b41466ff
No related branches found
No related tags found
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
check.go
+0
-2
0 additions, 2 deletions
check.go
with
0 additions
and
2 deletions
check.go
+
0
−
2
View file @
ec3841b6
...
@@ -111,8 +111,6 @@ func isSignedBy(cert, ca *x509.Certificate) bool {
...
@@ -111,8 +111,6 @@ func isSignedBy(cert, ca *x509.Certificate) bool {
return
cert
.
CheckSignatureFrom
(
ca
)
==
nil
return
cert
.
CheckSignatureFrom
(
ca
)
==
nil
}
}
// TODO: add "signedByCA()" check to verify that the certificate has been signed by the CA we have.
func
pkixEqual
(
a
,
b
pkix
.
Name
)
bool
{
func
pkixEqual
(
a
,
b
pkix
.
Name
)
bool
{
return
(
a
.
CommonName
==
b
.
CommonName
&&
return
(
a
.
CommonName
==
b
.
CommonName
&&
compareStringList
(
a
.
Country
,
b
.
Country
)
&&
compareStringList
(
a
.
Country
,
b
.
Country
)
&&
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment