Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
A
auth
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
id
auth
Merge requests
!34
Draft: Webauthn
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Draft: Webauthn
webauthn
into
master
Overview
0
Commits
3
Pipelines
4
Changes
2
Merged
ale
requested to merge
webauthn
into
master
3 years ago
Overview
0
Commits
3
Pipelines
4
Changes
2
Expand
0
0
Merge request reports
Viewing commit
6fa6e1f2
Prev
Next
Show latest version
2 files
+
41
−
30
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
2
Search (e.g. *.vue) (Ctrl+P)
6fa6e1f2
Do not log unused webauthn credential
· 6fa6e1f2
ale
authored
3 years ago
server/authserver.go
+
3
−
9
Options
@@ -548,18 +548,12 @@ func (s *Server) finishWebAuthnLogin(user *backend.User, sessionData *webauthn.S
wuser
:=
newWebAuthnUser
(
user
)
// Attempt non-legacy validation first.
cred
,
err
:=
s
.
webAuthnHandler
.
ValidateLogin
(
wuser
,
*
sessionData
,
parsedResponse
)
_
,
err
:=
s
.
webAuthnHandler
.
ValidateLogin
(
wuser
,
*
sessionData
,
parsedResponse
)
if
err
!=
nil
{
cred
,
err
=
s
.
compatWebAuthnHandler
.
ValidateLogin
(
wuser
,
*
sessionData
,
parsedResponse
)
if
err
!=
nil
{
return
err
}
_
,
err
=
s
.
compatWebAuthnHandler
.
ValidateLogin
(
wuser
,
*
sessionData
,
parsedResponse
)
}
// What do we do with this credential?
log
.
Printf
(
"cred: %v"
,
cred
)
return
nil
return
err
}
func
checkPassword
(
password
,
hash
[]
byte
)
bool
{
Loading