Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
K
keystore
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
id
keystore
Commits
63f23c47
Commit
63f23c47
authored
1 year ago
by
ale
Browse files
Options
Downloads
Patches
Plain Diff
Apparently protocol v3 still has no response to HELLO
The documentation seems to imply otherwise?
parent
ccbb1d30
No related branches found
No related tags found
No related merge requests found
Pipeline
#57994
passed
1 year ago
Stage: test
Stage: build
Stage: release
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
dovecot/dict.go
+0
-6
0 additions, 6 deletions
dovecot/dict.go
dovecot/dict_test.go
+0
-10
0 additions, 10 deletions
dovecot/dict_test.go
with
0 additions
and
16 deletions
dovecot/dict.go
+
0
−
6
View file @
63f23c47
...
@@ -72,12 +72,6 @@ func (p *DictProxyServer) handleHello(ctx context.Context, lw unix.LineResponseW
...
@@ -72,12 +72,6 @@ func (p *DictProxyServer) handleHello(ctx context.Context, lw unix.LineResponseW
return
fmt
.
Errorf
(
"unsupported protocol version %d"
,
majorVersion
)
return
fmt
.
Errorf
(
"unsupported protocol version %d"
,
majorVersion
)
}
}
// In version 3, HELLO expects a response.
if
majorVersion
==
3
{
s
:=
fmt
.
Sprintf
(
"O%d
\t
0"
,
majorVersion
)
return
lw
.
WriteLineCRLF
([]
byte
(
s
))
}
return
nil
return
nil
}
}
...
...
This diff is collapsed.
Click to expand it.
dovecot/dict_test.go
+
0
−
10
View file @
63f23c47
...
@@ -93,16 +93,6 @@ func makeTestRequest(t *testing.T, socketPath string, version int, lookupKey, ex
...
@@ -93,16 +93,6 @@ func makeTestRequest(t *testing.T, socketPath string, version int, lookupKey, ex
t
.
Fatalf
(
"error writing HELLO: %v"
,
err
)
t
.
Fatalf
(
"error writing HELLO: %v"
,
err
)
}
}
if
version
>
2
{
resp
,
err
:=
conn
.
ReadLine
()
if
err
!=
nil
{
t
.
Fatalf
(
"error reading HELLO response: %v"
,
err
)
}
if
resp
[
0
]
!=
'O'
{
t
.
Fatalf
(
"request returned unexpected status: %s"
,
resp
)
}
}
if
err
:=
conn
.
PrintfLine
(
"L%s"
,
lookupKey
);
err
!=
nil
{
if
err
:=
conn
.
PrintfLine
(
"L%s"
,
lookupKey
);
err
!=
nil
{
t
.
Fatalf
(
"error writing LOOKUP: %v"
,
err
)
t
.
Fatalf
(
"error writing LOOKUP: %v"
,
err
)
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment